79076349

Date: 2024-10-10 22:48:42
Score: 0.5
Natty:
Report link

The problem is that you're combining exported methods with inlining. Inlined methods don't need to be exported; pick one or the other. Alternately, you could do what Felix F Xu suggested, and move the function bodies to a .cpp file.

Also, I disagree with making the entire class exported; any classes referred to in private fields will have to be exported too. I find it less intrusive to just export the necessary methods.

Reasons:
  • No code block (0.5):
Posted by: ulatekh