The problem is that when you copy the Player object, the Vector of Hero objects still points to the same heroes as the original Player. So when you add the copied heroes, they end up showing up twice.

To fix this, just create a new Vector for each player's heroes when you're copying, so that the new Player gets its own heroes.