This behaviour is baffling for macOS users. Thankfully there are Settings options to tell VS Code to use the global macOS find clipboard: search for "global clipboard" in Settings and check both
Editor > Find: Global Find Clipboard
Search > Global Find Clipboard