For a docked terminal window in eclipse make sure you are using git/bin/bash.exe NOT git/git-bash.exe

git/bin/git-bash.exe opens in an external window
git/bash.exe opens in a docked window in eclipse

Both versions are otherwise functionally equivalent